Remove system-specific carriage returns

[rachelnabors]

Looks like there's a Window's specific carriage return goofing things up on my Mac:

Rachels-MacBook-Pro-2:reloaded rachel$ sonar
env: node\r: No such file or directory

Environment

Mac, running NVM. Am unable to create .sonarrc.

• __Node.js version: v8.6.0
• __npm version: 5.3.0

[molant]

Been talking with @rachelnabors, it looks like this happens with any command in the CLI.
Trying to pinpoint where the error comes from as @alrra is using a Mac and doesn't repro this with the latest version. Maybe an issue with nvm?

[alrra]

Maybe an issue with nvm?

The problem is not with nvm (I'm using it, and everything is working fine).

#!/usr/bin/env node was causing sonar to throw

#!/usr/bin/env node should be there so that the system knows what to use (i.e. node, not sh, or something else) when the file is executed directly, and not as node some_file.js.

From https://docs.npmjs.com/files/package.json#bin

"Please make sure that your file(s) referenced in bin starts with #!/usr/bin/env node, otherwise the scripts are started without the node executable!"

Note: I've reverted #564, as otherwise, something similar to this will happen for users when trying to execute sonar:

/Users/alrra/.nvm/versions/node/v8.1.3/bin/sonar: line 1: use strict: command not found
/Users/alrra/.nvm/versions/node/v8.1.3/bin/sonar: line 2: syntax error near unexpected token `exports,'
/Users/alrra/.nvm/versions/node/v8.1.3/bin/sonar: line 2: `Object.defineProperty(exports, "__esModule", { value: true });'

#!/usr/bin/env node was causing sonar to throw env: node\r: No such file or directory from the command line on my Mac.

The problem is that, for some reason, on @rachelnabors' system there is a \n after node, so the system tries to execute the file using node\r instead of node, which of course doesn't exist, hence No such file or directory.

Looks like there's a Window's specific carriage return goofing things up on my Mac:

I don't see any carriage return in the code, nor the generated code from dist/

[alrra]

@molant The problem is that when you did the release, since you did it from Windows, when the build process was executed it automatically inserted the \rs. :(

[alrra]

I published a new release that should fix this issue.

---

@rachelnabors Can you reinstall sonar, and confirm this issue has been fixed? Thanks!