Please fix the findChangedEntitiesAtRevision() for postgresql users. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e due to a bug FIXED: typo (Entites should be Entities)
…h a serialized diff-array on UPDATE.
…h a serialized diff-array on UPDATE.
…e configuration file.
…ou can set with AuditConfig#setCurrentDescription() just like the setCurrentUsername() method.
…erate process to mark a revision as processed. EntityReader#setRevisionProcessed() marks a revision as processed. EntityReader#findUnprocessedRevisions() returns unprocessed revisions.
…, entity id and revision.
…ty (5603d9b) failed on DateTime objects because DateTime doesn't have a toString method by default. Added code that flattens the diff array to a simple array using a configurable date format for DateTime objects.
…now" for the revisions.timestamp field. Useful for (unit)testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ue to a bug
FIXED: typo (Entites should be Entities)
Hi, I fixed two items in this commit. You might not want to fix the typo because it changes a public functions name. But there is one change that should be fixed, because the findChangedEntitiesAtRevision() didn't work on postgresql yet.