Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php8 #346

Closed
wants to merge 1 commit into from
Closed

Add php8 #346

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jan 25, 2021

I tried to install it locally, and it works fine.

@VincentLanglet VincentLanglet marked this pull request as ready for review January 25, 2021 14:44
@VincentLanglet
Copy link
Member Author

From #203 (comment)

@tolry
@beberlei
@DavidBadura
@smoench
@andrewtch
@merk

I know this project is not maintain anymore but does someone has time to merge and release this PR in order to at least still allow user to use it ?

@andrewtch
Copy link
Contributor

Let's wait for Travis to pass, at least :)

@smoench
Copy link
Contributor

smoench commented Jan 25, 2021

@VincentLanglet since this bundle was published under the LGPL license and it hasn't received any updates the last 3 years you are free to fork it.

As I can't recommend this bundle anymore please stop pinging me for any changes related to this project. Thanks you! :-)
Consider using EventSourcing instead ...

@VincentLanglet
Copy link
Member Author

Let's wait for Travis to pass, at least :)

Test can't run on php8 because they were written with phpunit 4.8...
It would require a lot of work to rewrite every test, and i'm not sure of the interest if the repository is not maintained.

My goal was to allow people with this dependency (for instance if they provide a bridge) to use php8.

@RobinDev
Copy link

Maybe we could skip adding PHP 8.0 to Travis and use this pattern in composer :

"php": ">=5.3.9",

@tolry
Copy link
Contributor

tolry commented Jan 26, 2021

As @smoench said, there is no active development going on.

Yesterday I spoke to @beberlei - who initially wrote this bundle - and he suggested for sonata to maybe pick up the bundle, because ~90% of the downloads for this bundle come from sonata users, since they recommend it in their documentation

I have no idea if they have any interest (or ressources) in working on this, but maybe that might be a good place to start a discussion?

@VincentLanglet
Copy link
Member Author

As @smoench said, there is no active development going on.

Yesterday I spoke to @beberlei - who initially wrote this bundle - and he suggested for sonata to maybe pick up the bundle, because ~90% of the downloads for this bundle come from sonata users, since they recommend it in their documentation

I have no idea if they have any interest (or ressources) in working on this, but maybe that might be a good place to start a discussion?

That could be an idea indeed. I don't personally use this bundle but I know that at least one of sonata maintainer does.

@wbloszyk @greg0ire @franmomu @OskarStark @phansys @dmaicher @core23 @jordisala1991
WDYT ?

@wbloszyk
Copy link
Member

IMHO this bundle is great to create database logs in sonata admin. I use it in some project and i wants use it in the new one. We should keep this functionality. I can help with contribiluting here or as sonata bundle.

@OskarStark
Copy link
Member

Why not, @beberlei would it be possible to move it to our organization while keeping the packagist package name for transition phase 1 and abandon it and add a new package name under sonata scope in transition phase 2?

If yes, you can add me to the repo and give me the needed access and I will move it ▶️

@tolry
Copy link
Contributor

tolry commented Jan 26, 2021

@OskarStark I also have packagist permissions on this package and could help out with this, but I would like to check in with someone from SimpleThings first and see if that's ok with them.

@tolry
Copy link
Contributor

tolry commented Jan 27, 2021

@OskarStark I got the 🟢 from SimpleThings to transfer the package, can I simply add someone from Sonata to the list of packagist maintainers and you'll take it from there? Just need packagist-username for that, thanks.

@OskarStark
Copy link
Member

HI @tolry, thank you!

First I need Admin access to this repository to transfer it to sonata-project organization on github

@tolry
Copy link
Contributor

tolry commented Jan 28, 2021

@OskarStark you should have an invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants