Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing space in identifier WHERE clausule if the entity has multiple columns as the primary key #398

Merged
merged 1 commit into from
May 31, 2021

Conversation

Vantomas
Copy link
Contributor

Subject

There is a problem if the entity has multiple columns as the primary key. In this case EntityAuditBundle ends with a SyntaxErrorException.

Doctrine\DBAL\Driver\Mysqli\Exception\ConnectionError: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '?AND itemid = ?' at line 1 in /Users/vantomas/Projekty/lms-dev/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/Mysqli/Exception/ConnectionError.php:19

Next Doctrine\DBAL\Exception\SyntaxErrorException: An exception occurred while executing 'UPDATE invoicecontents_audit SET docid = ? WHERE rev = ? AND docid = ?AND itemid = ?' with params [343765, 149657, 343765, 1]:

I am targeting this branch, because it's without BC-break.

Changelog

### Fixed
- Fix missing space in identifier WHERE clausule if the entity has multiple columns as the primary key

@core23 core23 added the patch label May 31, 2021
@VincentLanglet VincentLanglet merged commit 1bac20e into sonata-project:1.x May 31, 2021
@VincentLanglet
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants