Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use event_listener instead of event_subscriber #583

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Aug 1, 2023

Subject

I am targeting this branch, because it should be BC.

Changelog

### Fixed
- Deprecation of Event Subscribers on Symfony 6.3. They now uses Event Listeners

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of tests are failing here...

src/EventListener/CreateSchemaListener.php Show resolved Hide resolved
@VincentLanglet
Copy link
Member

I think less tests are failing

@Hanmac
Copy link
Contributor Author

Hanmac commented Aug 2, 2023

hm i don't know what causes this some_strange_key_name one to fail ?

@franmomu
Copy link
Member

franmomu commented Aug 2, 2023

hm i don't know what causes this some_strange_key_name one to fail ?

I guess is the last release of doctrine/orm (2.16), I've created #584

@VincentLanglet
Copy link
Member

hm i don't know what causes this some_strange_key_name one to fail ?

I guess is the last release of doctrine/orm (2.16), I've created #584

It's merged, please rebase

@VincentLanglet VincentLanglet merged commit f8a614d into sonata-project:1.x Aug 3, 2023
41 checks passed
@Hanmac Hanmac deleted the eventListener branch August 3, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants