Add missing deprecation message and warning for Exporter #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
exporter-deprecation-improve
branch
from
c88e866
to
4d21fb9
Compare
|
@sonata-project/contributors PR ready for review. |
|
Could you please rebase your PR and fix merge conflicts? |
|
Can we close this in favor of #4029 ? |
imo yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because it's a fix.
Changelog
To do
Subject
The class was deprecated on ba17aa0 but without any indication.