Fix JS loading in autocomplete form type #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger the select2-JavaScript code at onload event
greg0ire
approved these changes
Aug 18, 2017
jlamur
approved these changes
Aug 18, 2017
|
Thanks @juchi ! |
pestaa
pushed a commit
to Crosssec/SonataAdminBundle
that referenced
this pull request
Aug 31, 2017
Trigger the select2-JavaScript code at onload event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this change is backward compatible.
Changelog
Subject
The autocomplete model form type uses Select2 to render the dropdown. However the code runs before the onload JS event, which is not compatible with loading the JS files at the end of the page.
This changes allows one to change the standard_layout template and move the JavaScript files (except jQuery) to the end of the HTML page.