Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to use deprecated ContainerAwareCommand #5579

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Avoid to use deprecated ContainerAwareCommand #5579

merged 1 commit into from
Jun 19, 2019

Conversation

phansys
Copy link
Member

@phansys phansys commented Jun 8, 2019 •
edited
Loading

Subject

Avoid to use deprecated ContainerAwareCommand

I am targeting this branch, because these changes are BC.

To do

  • Update remaining classes;
  • Update tests;
  • Check if these classes should be marked as final.

@phansys phansys marked this pull request as ready for review June 8, 2019 12:00
@greg0ire
Copy link
Contributor

greg0ire commented Jun 8, 2019

Here is some inspiration for you sonata-project/SonataCacheBundle#251

Check if these classes should be marked as final.

They should, but on a separate PR to master.

@phansys phansys changed the title Avoid to use deprecated ContainerAwareCommand [WIP] Avoid to use deprecated ContainerAwareCommand Jun 8, 2019
@phansys phansys changed the title [WIP] Avoid to use deprecated ContainerAwareCommand Avoid to use deprecated ContainerAwareCommand Jun 9, 2019
@phansys phansys added the patch label Jun 18, 2019
@phansys phansys requested a review from greg0ire June 19, 2019 13:20
@greg0ire greg0ire merged commit b035052 into sonata-project:3.x Jun 19, 2019
@greg0ire
Copy link
Contributor

Thanks @phansys !

@phansys phansys deleted the commands branch June 19, 2019 20:13
@phansys phansys mentioned this pull request Apr 28, 2020
Closed
@phansys phansys mentioned this pull request Jul 14, 2020
Merged
@VincentLanglet VincentLanglet mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @greg0ire @OskarStark