Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple editable field should be real multiple #5773

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Dec 3, 2019

Subject

Multiple editable field should be real multiple.

image

Now a multiple field is shown as multiple but edit is not a multiple and new value will be overridden, not append.

image

image

image

Closes #5767

Changelog

### Added
- Multiple editable fields now is a real multiple.

core23
core23 previously approved these changes Dec 11, 2019
@greg0ire
Copy link
Contributor

greg0ire commented Jan 1, 2020

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

  1. git rebase -i origin/3.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

Also, please format your commit message according to our rules :

  • The commit message subject must be less than 50 characters and tell us what you did.
  • The commit message body should tell us why you did it. It is optional but highly recommended.

Bad example :

Fixed bug #989 by removing call to defraculate()

Good example:

Remove call to defraculate()

Calling this function caused a bug because it interferes 
with calls to getSchmeckles().
Fixes #989

More details in CONTRIBUTING.md

Simple check boolean variables
Add example usage in docs
Add test for template
Test set object field editable multiple value
@peter-gribanov
Copy link
Contributor Author

@greg0ire i squash commits

@greg0ire greg0ire merged commit 2455306 into sonata-project:3.x Jan 2, 2020
@greg0ire
Copy link
Contributor

greg0ire commented Jan 2, 2020

Thanks @peter-gribanov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple choses in editable 'choice' type in List fields
3 participants