Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony security-csrf and asset 5.1 #6363

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Sep 1, 2020

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Allow `symfony/security-csrf` and `symfony/asset` ^5.1

VincentLanglet
VincentLanglet previously approved these changes Sep 1, 2020
composer.json Outdated Show resolved Hide resolved
@wbloszyk wbloszyk mentioned this pull request Sep 2, 2020
20 tasks
@wbloszyk
Copy link
Member

wbloszyk commented Sep 2, 2020

@jordisala1991
Could you move this PR to master branch? We can't add support for Symfony5 in Sonata3 becouse Symfony 5 - TODO list

@jordisala1991
Copy link
Member Author

This change does not break bc, so it can be done on 3.x (I will revert the security-core)

@franmomu
Copy link
Member

franmomu commented Sep 2, 2020

This change does not break bc, so it can be done on 3.x (I will revert the security-core)

Can you please also add symfony/asset 😬 ? https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Asset/CHANGELOG.md apparently there is no problem.

@wbloszyk
Copy link
Member

wbloszyk commented Sep 2, 2020

@jordisala1991
I know this is not BC-break. I mean something else. Some symfony bundle must be with symfony version. What is point to add support for 5.x when install it will be imposible? That why I ask about move it to master.

@jordisala1991
Copy link
Member Author

Because people usually do not have all possible symfony dependencies fixed on 4.4 or use flex like this:

    "extra": {
        "symfony": {
            "allow-contrib": true,
            "require": "^4.4 || ^5.1"
        }
    },

So if a package is compatible, I am happy with getting an upgrade. I don't care if I don't have all possible packages upgraded

@jordisala1991 jordisala1991 requested a review from a team September 2, 2020 10:41
@jordisala1991 jordisala1991 changed the title Allow symfony security csrf and core 5.1 Allow symfony security-csrf and asset 5.1 Sep 2, 2020
@franmomu franmomu merged commit d54497d into sonata-project:3.x Sep 2, 2020
@franmomu
Copy link
Member

franmomu commented Sep 2, 2020

Thanks @jordisala1991!

@jordisala1991 jordisala1991 deleted the feature/allow-security-5.1 branch September 2, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants