Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code and add final #7310

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Remove unused code and add final #7310

merged 3 commits into from
Jul 12, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 10, 2021 •
edited
Loading

I used psalm to detect unused code in tests.
I also added final keyword to them.

Changelog

## Changed
- Remove unused code and add some `final` keyword

@VincentLanglet VincentLanglet requested a review from a team July 10, 2021 12:09
@VincentLanglet VincentLanglet requested a review from a team July 11, 2021 09:08
@VincentLanglet VincentLanglet merged commit c6e8d73 into sonata-project:master Jul 12, 2021
@VincentLanglet VincentLanglet deleted the unused branch July 12, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @dmaicher @jordisala1991