Upgrade adminLTE to v3 #7740

jordisala1991 · 2022-02-13T09:59:49Z

Subject

I am targeting this branch, because this breaks BC.

Changelog

### Added
- Added support for AdminLTE v3
- Added support for jQuery v3

VincentLanglet · 2022-02-13T10:01:28Z

It requires to target 5.x, isn't it ?

jordisala1991 · 2022-02-13T10:03:16Z

For the moment there are some PR on the frontend that didn't land in 5.x yet (I think). Also I would like to understand what changes are needed to be compatible with AdminLTE 3. This way we can decide if it is worth to do it on 4.x or 5.x. Of coure it will be done probably on 5.x since it will require a lot of changes. Still I don't know yet how many things needs to be changed.

VincentLanglet · 2022-02-13T10:08:30Z

For the moment there are some PR on the frontend that didn't land in 5.x yet (I think). Also I would like to understand what changes are needed to be compatible with AdminLTE 3. This way we can decide if it is worth to do it on 4.x or 5.x. Of coure it will be done probably on 5.x since it will require a lot of changes. Still I don't know yet how many things needs to be changed.

Dropping bootstrap3 in favor of bootstrap4 is a BC-break to me since it can break the html/css a user added on a custom templates. Also, we're dropping xeditable and the related feature. So it will be 5.x.

But I'm curious to see how hard it is to have this update.
Do you try this on a custom project ? Having screenshot would be interesting :)

jordisala1991 · 2022-02-13T10:14:42Z

For the moment there are some PR on the frontend that didn't land in 5.x yet (I think). Also I would like to understand what changes are needed to be compatible with AdminLTE 3. This way we can decide if it is worth to do it on 4.x or 5.x. Of coure it will be done probably on 5.x since it will require a lot of changes. Still I don't know yet how many things needs to be changed.

Dropping bootstrap3 in favor of bootstrap4 is a BC-break to me since it can break the html/css a user added on a custom templates. Also, we're dropping xeditable and the related feature. So it will be 5.x.

But I'm curious to see how hard it is to have this update. Do you try this on a custom project ? Having screenshot would be interesting :)

For now I did the changes needed to be able to compile assets, my next step would be to install this version on a custom project to see how it renders

As you said it will be landing on 5.x unless something magic happens like something like this working great: https://www.npmjs.com/package/bootstrap-4-migrate

eerison · 2022-02-28T14:00:36Z

Hey @jordisala1991 I tried to use your branch to see how the new admin looks like, but I saw many things are not working

questions

could you list what is finished and what is missing
what you are fixing ATM
if I fix something how can I put in your branch? should I open a PR to your branch?

Edit 1: or do you think is easier just one person work on that

eerison · 2022-02-28T20:15:36Z

@jordisala1991 I'm fixing the sidebar menu on the left side

old one:

new one:

what is missing

fix the show/hide menu
sub menus

when I fix that I can open a MR for your branch

eerison · 2022-02-28T20:49:30Z

I need to override this submenu's <li> I guess it's from KNP menu, but do you have any easy way to change this? if not I'll search a bit ;)

I need to add class="nav-item"

cc @VincentLanglet

VincentLanglet · 2022-02-28T22:13:42Z

I need to override this submenu's
I guess it's from KNP menu, but do you have any easy way to change this? if not I'll search a bit ;)

You should look at Menu/sonata_menu.html.twig. Maybe the {% block item %}

eerison · 2022-03-02T22:04:12Z

Ok just an update!

the layout is basically done, I'm with a problem to make this treeview/dropdown work, I'm not sure if it's missing some js ...

eerison · 2022-03-03T14:48:56Z

webpack.config.js

@@ -53,11 +53,6 @@ Encore.setOutputPath('./src/Resources/public')

  .copyFiles([
    { from: './assets/images/', pattern: /\.(png|gif)$/, to: 'images/[name].[ext]' },
-    {


I guess it's important to skins?

because I'm getting this error

GET http://localhost:8001/bundles/sonataadmin/admin-lte-skins/skin-black.min.css net::ERR_ABORTED 404 (Not Found)

I didn't find the skins on the admin-lte v3, maybe we need to remove that feature too.

I found this

https://adminlte.io/docs/3.1//additional-styles.html

core23 · 2022-03-04T13:56:12Z

When updating to admin lte, maybe you can look for some custom html attributes like sonata-filter which should be data-sonata-filter.

I tried this few years ago: https://github.com/sonata-project/SonataAdminBundle/pull/3312/files

This would close #5132

Fixing menu leftside

SonataCI · 2022-03-07T17:23:39Z

Could you please rebase your PR and fix merge conflicts?

eerison · 2022-03-30T19:41:49Z

I am working on the header nav bar now, and will finish the sidebar last touches

Nice 👏👏

jordisala1991 · 2022-04-03T10:07:48Z

Fixed sidebar, now it opens and closes. Also minor fixes on styles for the sidebar and the header bar.
The main sonata dashboard is fixed too (there are more widgets that need to be tested tho)
The main sonata form now looks better.

There is still a lot of work to do.

SonataCI · 2022-04-28T07:03:06Z

Could you please rebase your PR and fix merge conflicts?

github-actions · 2022-10-25T09:07:34Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

eerison · 2022-11-01T10:26:03Z

👀

core23 · 2023-08-27T10:31:08Z

Hi @jordisala1991, can you give a short update what parts were missing / done?

I'd like to continue on this topic in the next weeks.

jordisala1991 · 2023-08-30T16:29:57Z

This pr was missing a lot of things, but it is really old, I cant remember exactly. My last attempt was with bootstrap directly, last released version contains everything that we might need. Adminlte is no longer needed imho.

Upgrade adminLTE to v3

9ec6e98

jordisala1991 force-pushed the feature/upgrade-admin-lte branch from 92277ed to 9ec6e98 Compare February 13, 2022 10:06

jordisala1991 added 7 commits February 27, 2022 20:11

Should not include bootstrap css since it is inside admin-lte

36644ab

Fix sidebar menu

f7538b5

Fix sidebar

73d1a92

move logo

d641c41

more fixes

6c90b9a

Fix sidebar toggle

65ccda0

more sidebar menu fixes

41146f8

eerison reviewed Mar 3, 2022

View reviewed changes

eerison and others added 4 commits March 7, 2022 14:47

move logo

91a0c91

Merge branch 'feature/upgrade-admin-lte' into fix-navbar-leftside

45aa6ee

Fixed search button

c5b74d2

Merge pull request #3 from eerison/fix-navbar-leftside

bc94f0a

Fixing menu leftside

SonataCI added the pending author label Mar 7, 2022

eerison added 4 commits March 8, 2022 01:12

Fix breadcrumb

c7264ca

fixing select2 theme

da122ce

yeah dev to build js dependencies

52545e0

Fix filter

3488cab

jordisala1991 added 11 commits March 31, 2022 09:49

Fix header navbar

5b35d57

Try to fix admin dashboard block list

b2d2138

Improve dashboard admin list block

db4b05f

Improve styles

24222d4

Fix card

12251ab

Sidebar adjust search

4033bdf

Improve brand image

e73064b

fix sidebar menu

786e95b

Update search form

e896449

Fix breadcrumb

09824e2

Fix forms

d443f9b

jordisala1991 added 5 commits April 3, 2022 15:42

Remove conflicting style

cef397e

Fix main content title

9dbaaad

Improve list view

2b361f4

Fix footer form actions

ec81641

Remove border on menu

0c61852

SonataCI added the pending author label Apr 28, 2022

github-actions bot added the stale label Oct 25, 2022

github-actions bot closed this Nov 1, 2022

VincentLanglet mentioned this pull request Dec 27, 2022

Frontend Upgrade #7156

Open

5 tasks

VincentLanglet mentioned this pull request Aug 30, 2023

admin-lte js package 2.4 is concerned by known critical vulnerabilities #8095

Closed

SonataCI removed the pending author label Aug 30, 2023

core23 mentioned this pull request Sep 18, 2023

Upgrade to AdminLTE 3 #8103

Closed

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade adminLTE to v3 #7740

Upgrade adminLTE to v3 #7740

jordisala1991 commented Feb 13, 2022 •

edited

VincentLanglet commented Feb 13, 2022

jordisala1991 commented Feb 13, 2022

VincentLanglet commented Feb 13, 2022

jordisala1991 commented Feb 13, 2022

eerison commented Feb 28, 2022 •

edited

eerison commented Feb 28, 2022 •

edited

eerison commented Feb 28, 2022 •

edited

VincentLanglet commented Feb 28, 2022

eerison commented Mar 2, 2022

eerison Mar 3, 2022

jordisala1991 Mar 3, 2022

eerison Mar 17, 2022 •

edited

core23 commented Mar 4, 2022 •

edited

SonataCI commented Mar 7, 2022

eerison commented Mar 30, 2022

jordisala1991 commented Apr 3, 2022

SonataCI commented Apr 28, 2022

github-actions bot commented Oct 25, 2022

eerison commented Nov 1, 2022

core23 commented Aug 27, 2023

jordisala1991 commented Aug 30, 2023

Upgrade adminLTE to v3 #7740

Upgrade adminLTE to v3 #7740

Conversation

jordisala1991 commented Feb 13, 2022 • edited

Subject

Changelog

VincentLanglet commented Feb 13, 2022

jordisala1991 commented Feb 13, 2022

VincentLanglet commented Feb 13, 2022

jordisala1991 commented Feb 13, 2022

eerison commented Feb 28, 2022 • edited

eerison commented Feb 28, 2022 • edited

eerison commented Feb 28, 2022 • edited

VincentLanglet commented Feb 28, 2022

eerison commented Mar 2, 2022

eerison Mar 3, 2022

Choose a reason for hiding this comment

jordisala1991 Mar 3, 2022

Choose a reason for hiding this comment

eerison Mar 17, 2022 • edited

Choose a reason for hiding this comment

core23 commented Mar 4, 2022 • edited

SonataCI commented Mar 7, 2022

eerison commented Mar 30, 2022

jordisala1991 commented Apr 3, 2022

SonataCI commented Apr 28, 2022

github-actions bot commented Oct 25, 2022

eerison commented Nov 1, 2022

core23 commented Aug 27, 2023

jordisala1991 commented Aug 30, 2023

jordisala1991 commented Feb 13, 2022 •

edited

eerison commented Feb 28, 2022 •

edited

eerison commented Feb 28, 2022 •

edited

eerison commented Feb 28, 2022 •

edited

eerison Mar 17, 2022 •

edited

core23 commented Mar 4, 2022 •

edited