Cast field name to match parameter requirements #7983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toooni
commented
Dec 6, 2022
| @@ -51,6 +50,22 @@ public function testHasChildren(): void | |||
| { | |||
| $this->builder->add('name', TextType::class); | |||
| $iterator = new FormBuilderIterator($this->builder); | |||
| static::assertTrue($iterator->hasChildren()); | |||
| static::assertFalse($iterator->hasChildren()); | |||
There was a problem hiding this comment.
I've changed from using a stub of FormFactoryInterface to using an instance of FormFactory. This resulted in this test to fail. After checking what hasChildren does, I don't think this test was ever correct and only resulted in the expected result because it was a stub.
hasChildren checks if the children of current have children. This is not the case if we have one single TextType.
There was a problem hiding this comment.
Then can you add a hasChildren test when we have the true response too ?
toooni
commented
Dec 6, 2022
|
|
||
| /** | ||
| * @author Mike Meier <mike.meier@ibrows.ch> | ||
| */ | ||
| final class FormBuilderIteratorTest extends TestCase | ||
| { | ||
| private EventDispatcherInterface $dispatcher; |
There was a problem hiding this comment.
I've removed dispatcher and factory properties from the class and replaced them with vars inside setUp since they are not used anywhere else.
|
Thanks, it was fixed in #7985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Closes comment in discussion sonata-project/form-extensions#368 (comment).
Changelog