fix issue with integer indexed form children #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Dec 8, 2022
| @@ -53,4 +54,11 @@ public function testHasChildren(): void | |||
| $iterator = new FormBuilderIterator($this->builder); | |||
| static::assertTrue($iterator->hasChildren()); | |||
| } | |||
|
|
|||
| public function testCurrentWithIntegerIndexedChildren(): void | |||
There was a problem hiding this comment.
this fails without the fix
There was 1 error:
1) Sonata\AdminBundle\Tests\Util\FormBuilderIteratorTest::testCurrentWithIntegerIndexedChildren
TypeError: Symfony\Component\Form\FormBuilder::get(): Argument #1 ($name) must be of type string, int given, called in /var/www/SonataAdminBundle/src/Util/FormBuilderIterator.php on line 67
/var/www/SonataAdminBundle/vendor/symfony/form/FormBuilder.php:91
/var/www/SonataAdminBundle/src/Util/FormBuilderIterator.php:67
/var/www/SonataAdminBundle/tests/Util/FormBuilderIteratorTest.php:62
/var/www/SonataAdminBundle/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/var/www/SonataAdminBundle/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
/var/www/SonataAdminBundle/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
/var/www/SonataAdminBundle/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
dmaicher
force-pushed
the
fix_issue_7984
branch
from
b93c8a4
to
cc06189
Compare
|
Weird failures seem unrelated |
Might be related to symfony/symfony#48422 Should be skip the test for now ? |
dmaicher
force-pushed
the
fix_issue_7984
branch
from
b1534df
to
5e5dc4e
Compare
dmaicher
force-pushed
the
fix_issue_7984
branch
from
5e5dc4e
to
9f69602
Compare
VincentLanglet
approved these changes
Dec 8, 2022
|
I'll take care of psalm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because its BC and a bug fix.
Closes #7984
Changelog