Deprecate null template for BlockContext #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
template
branch
from
10d6fde
to
019d9cb
Compare
VincentLanglet
force-pushed
the
template
branch
2 times, most recently
from
c8de5c5
to
017fd99
Compare
jordisala1991
previously approved these changes
Jan 30, 2022
src/Model/BaseBlock.php
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| namespace Sonata\BlockBundle\Model; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
We are not using uses for this. Prefer prefix with \
VincentLanglet
force-pushed
the
template
branch
from
017fd99
to
bf68a98
Compare
VincentLanglet
force-pushed
the
template
branch
from
bf68a98
to
2bee752
Compare
jordisala1991
previously approved these changes
Jan 30, 2022
|
I added a NEXT_MAJOR comment for the toString method, and found some missing typehint in final class, so I added them. @jordisala1991 |
jordisala1991
approved these changes
Jan 30, 2022
core23
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Closes #855.
Changelog