Allow blockContext without template #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fixDeprecation
branch
2 times, most recently
from
acce6be
to
7d92969
Compare
jordisala1991
previously approved these changes
Mar 7, 2022
|
Could you please rebase your PR and fix merge conflicts? |
VincentLanglet
force-pushed
the
fixDeprecation
branch
from
7d92969
to
92c8dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
SonataAdmin is using BlockContext without template. The template is provided instead by the admin.
I think it's fine to not provide a template then. But we should have the deprecation for null template in the getter then.
Changelog