deprecate more caching related things within BlockContextManager #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
deprecate_cache
branch
2 times, most recently
from
22cc0ba
to
e1c769e
Compare
dmaicher
force-pushed
the
deprecate_cache
branch
from
e1c769e
to
e05ed97
Compare
dmaicher
force-pushed
the
deprecate_cache
branch
from
e05ed97
to
03d0923
Compare
VincentLanglet
requested changes
Apr 19, 2022
dmaicher
commented
Apr 20, 2022
VincentLanglet
approved these changes
Apr 20, 2022
franmomu
approved these changes
Apr 21, 2022
| } | ||
|
|
||
| // NEXT_MAJOR: remove | ||
| if (null !== $logger) { |
There was a problem hiding this comment.
Just a comment, maybe we could check with func_num_args in these kind of deprecations to avoid also passing null.
There was a problem hiding this comment.
yeah will keep it in mind for next time 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Deprecate
$cacheBlocksargument onBlockContextManager::__construct.I overlooked this in #1011.
Changelog