Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more missing deprecations for caching functionality #1045

Merged
merged 1 commit into from
Apr 23, 2022
Merged

more missing deprecations for caching functionality #1045

merged 1 commit into from
Apr 23, 2022

Conversation

dmaicher
Copy link
Contributor

Subject

See #1044 (comment)

Needed for removal on 5.x.

Changelog

### Deprecated
- deprecated method `AbstractBlockService::renderPrivateResponse()` 
- deprecated option `cache_policy` on `MenuBlockService`

@dmaicher dmaicher marked this pull request as ready for review April 23, 2022 10:47
@dmaicher dmaicher added the minor label Apr 23, 2022
@dmaicher dmaicher merged commit 3bdce79 into sonata-project:4.x Apr 23, 2022
@dmaicher dmaicher deleted the more_caching_deprecations branch April 23, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmaicher @VincentLanglet