Avoid hasChildren deprecation #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Jul 26, 2022
|
Since we're rely on the fact we're iterating on Blocks, I removed the |
|
sad I will need to open the code to fix this... tomorrow then. |
jordisala1991
force-pushed
the
jordisala1991-patch-1
branch
4 times, most recently
from
62ea6a2
to
59d6fd1
Compare
VincentLanglet
previously approved these changes
Jul 27, 2022
jordisala1991
force-pushed
the
jordisala1991-patch-1
branch
from
59d6fd1
to
04370a5
Compare
jordisala1991
commented
Jul 27, 2022
| @@ -199,7 +199,7 @@ public function addChildren(BlockInterface $children): void | |||
| $children->setParent($this); | |||
| } | |||
|
|
|||
| public function getChildren(): iterable | |||
| public function getChildren() | |||
There was a problem hiding this comment.
Had to change this to fix phpstan
jordisala1991
commented
Jul 27, 2022
| */ | ||
| public function getChildren(): iterable; | ||
| public function getChildren(); |
There was a problem hiding this comment.
I think you can keep the return type.
public function getChildren(): iterable;
There was a problem hiding this comment.
It breaks phpstan.
VincentLanglet
approved these changes
Jul 27, 2022
| */ | ||
| public function getChildren(): iterable; | ||
| public function getChildren(); |
There was a problem hiding this comment.
I think you can keep the return type.
public function getChildren(): iterable;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Changelog