Add configureSettings to block service

[soullivaneuh]

AbstractBlockService::configureSettings fixes Symfony deprecation issue.
BlockServiceInterface::setDefaultSettings is now deprecated.

Fixes #201

@rande Please don't merge it now! :-)

[soullivaneuh]

I have to check against built-in services.

[rande]

I think this should be compute once with a CompilerPass to avoid performance impact on using the reflection API.

[soullivaneuh]

How a CompilerPass will help to detect and throw deprecation errors?

I did the same method as Symfony. Please see: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/ResolvedFormType.php#L201-L207

[rande]

You can store an array with the result of the reflection and still send a trigger. Or at least store the result for one service to avoid doing the same over and over if a Page is composed of the same block.

[soullivaneuh]

To be honest, I have some difficulties to see what you want.

Can you maybe propose a PR on this one to show me?

[rande]

Something like this.

$this->reflectionCache = [
 'class\path' => ['isOldOverwritten' => true|false, 'isNewOverwritten' => true|false
];


$class = get_class($service);
if ($this->reflectionCache[$class]['isOldOverwritten'] && !$this->reflectionCache[$class]['isNewOverwritten']) {
        trigger_error('The Sonata\BlockBundle\Block\BlockServiceInterface::setDefaultSettings() method is deprecated since version 2.3 and will be removed in 3.0. Use configureSettings() instead. This method will be added to the BlockServiceInterface with SonataBlockBundle 3.0.', E_USER_DEPRECATED);
 }

[rande]

The reflectionCache cache attribute can either be compute once at with a CompilerPass or at runtime.

[soullivaneuh]

Ok I'll try. 👍

[soullivaneuh]

@rande Reflection cache is on the place. 👍

[rande]

Did you plan to add unit test ?

[soullivaneuh]

@rande Unit tests are already here for those classes.

I'm missing something?

[soullivaneuh]

Tests updated to fix deprecation notice errors.

AFAIK, the coverage still the same.

[sagikazarmark]

There is no need to cache reflection objects. See this benchmark: https://gist.github.com/mindplay-dk/3359812

[sagikazarmark]

@soullivaneuh PR sent for all the remaining open issues