-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to "Your First Block" documentation. #348
Conversation
Oh wow… 37 commits… I think you need to rebase… |
Could you please rebase your PR and fix merge conflicts? |
To be honest, I have not done very many pull requests via GitHub. Can you give me a suggestion for what I should do? |
You should do the following :
Try never to do that please ;) . You can always overwrite things thanks to |
Thank you for instructions, I will hopefully get this right soon :) |
I see you tried again, but it looks like you forgot the
It's a bit more simple :) |
Augh, thank you. I went through like 19 merge conflicts and I was hoping that would have done it. I'll try your new instructions. Thank you for the quick response. |
Hmm, I feel like I did your instructions on the wrong branch. I did them for 3.x and it was a lot cleaner, but the PR is for patch-1? |
First step is resetting |
Also, if you want to better understand what is happening, use |
After step 1, you should be on 150d8d5 (or maybe an older version, shouldn't be too serious) |
07e3834
to
fd2b7a0
Compare
Thank you kindly for your patient support. I think I got it pushed up correctly now? I totally did miss step 0. |
Yaaaay! Yes you did! Good job! |
Please run |
I ran into this while trying to create my first block in the Sonata Admin bundle. The documentation at this point did not work for version 3.2.0 of the Block Bundle, so I added a note about how to make it work.
fd2b7a0
to
3bdd7f3
Compare
Of all the things, I even had a typo, hahahaha. But yes, a lot easier now :). Again, I very much appreciate the help. |
And I'm glad you didn't give up! @sonata-project/contributors , please review! |
I refused to let my attempt at improving documentation languish ;) |
Way to go! |
I would rather change the setDefaultSettings() to configureOptions() instead of adding a note |
You're right @OskarStark ! @aleksandrmelnikov , please do that, and optionally invert the note :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please invert the note and change the doc
ping @aleksandrmelnikov |
I created a new PR in #373 |
I am targeting this branch, because the documentation update has to do with the block-bundle version 3.2.0. I assume this bundle is available only in the 3.x branch.
Changelog