prevent notice if $arguments is an empty array #378
Conversation
There was a problem hiding this comment.
Your PR subject
if services are defined through annotations the arguments are modified later -> therefore the $arguments variable is an empty array at this point. which in return causes the error if [0] is accessed
would make a great commit message. Please amend and force push
sry - I do not understand what you mean? The PR Subject is the same as the commit message I used. Should I change that to something else?
git commit --amend- copy paste that below the commit message subject, into the commit message body
git push --force
if a service is defined through annotation the arguments are set later. Therefore the $arguments variable is empty at this point. Which in return causes the notice if [0] is accessed
|
Changed the commit - I modified the message and added the whole subject to the optional message edit: I deleted the previous comment because I realized what you meant. thanks :) |
I thought it was a bug, didn't see the change ^^ Great job! |
|
It should contain a changelog, this is a patch right? |
|
I drafted one, you can improve it if you want @wodka |
|
changelog entry is fine for me this way, thank you! |
|
Changed: services -> blocks |
I am targeting this branch, because this error was introduced in the 3.3 version.
Closes #374
Subject
if services are defined through annotations the arguments are modified later -> therefore the $arguments variable is an empty array at this point. which in return causes the error if [0] is accessed
Changelog