Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if menuRegistry is not empty in MenuBlockService #382

Closed
wants to merge 2 commits into from
Closed

check if menuRegistry is not empty in MenuBlockService #382

wants to merge 2 commits into from

Conversation

mar20
Copy link

@mar20 mar20 commented May 10, 2017 •
edited by OskarStark

I am targeting this branch, because sonata.page.block.breadcrumb don't work

Closes #381

Changelog

### Fixed
- empty menuRegistry in ``MenuBlockService``

OskarStark
OskarStark requested changes May 10, 2017
View reviewed changes
Copy link
Member

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

@greg0ire
Copy link
Contributor

Please associate your burdamedia.pl email address with your Github account, or change the email in your commits to an address already associated with it.

@mar20
Copy link
Author

mar20 commented May 10, 2017

greg0ire, ok I add this email.
OskarStark - What do you mean by a test ? This is such a small bug fix

@OskarStark
Copy link
Member

OskarStark commented May 11, 2017 •
edited

OskarStark - What do you mean by a test ? This is such a small bug fix

Please check the MenuBlockServiceTest, if your code is tested in a positive and negativ case

@OskarStark OskarStark changed the title fix(MenuBlockService) - check if menuRegistry is not empty check if menuRegistry is not empty in MenuBlockService May 11, 2017
core23
core23 requested changes Jun 14, 2017
View reviewed changes
Block/Service/MenuBlockService.php
@@ -156,7 +156,9 @@ protected function getFormSettingsKeys()
$choices = $this->menus;

if (count($choices) == 0) {
$choices = $this->menuRegistry->getAliasNames();
if (!empty($this->menuRegistry)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please combine both if clauses.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @mar20

@SonataCI
Copy link
Collaborator

SonataCI commented Nov 2, 2017

Could you please rebase your PR and fix merge conflicts?

@jordisala1991
Copy link
Member

After this PR: #435

This one does not make sense anymore. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 requested changes

@OskarStark OskarStark OskarStark requested changes

Assignees
No one assigned
Labels
Needs: Tests patch pending author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mar20 @greg0ire @OskarStark @SonataCI @jordisala1991 @core23 @marcinkowskim