Only add classes to compile on PHP < 7.0 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addClassesToCompile is deprecated and doesn't improve performances on PHP > 7.0
greg0ire
approved these changes
Jun 19, 2017
OskarStark
approved these changes
Jun 20, 2017
| @@ -72,7 +72,9 @@ public function load(array $configs, ContainerBuilder $container) | |||
| $this->configureProfiler($container, $config); | |||
| $this->configureException($container, $config); | |||
| $this->configureMenus($container, $config); | |||
| $this->configureClassesToCompile(); | |||
| if (\PHP_VERSION_ID < 70000) { | |||
There was a problem hiding this comment.
It would be more readable to use version_compare IMHO.
There was a problem hiding this comment.
I personally prefer using the constant:
- It's what symfony uses in it's codebase
- The php optimizer can optimize it and remove this part of code on the corresponding php versions
There was a problem hiding this comment.
@soullivaneuh do you know why they choose to do it like this in sf?
There was a problem hiding this comment.
@greg0ire it's done to allow the optimization of opcodes : symfony/symfony#12497
There was a problem hiding this comment.
Yeah plus it's less error prone, and it's still easy to ready with such a constant.
There was a problem hiding this comment.
In this case, go for it.
It would be a great Fixer idea for php-cs-fixer BTW...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this fix a deprecation warning and is BC.
Changelog
Subject
Only call addClassesToCompile on PHP < 7.0 since it is deprecated and doesn't improve performances with PHP >= 7.0