Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Merge #472

Merged
merged 9 commits into from
Feb 2, 2018
Merged

Conversation

kunicmarko20
Copy link
Contributor

Don't merge, just approve.

covex-nn and others added 8 commits January 16, 2018 07:39
…#457)

* Update composer.json deps

* Referencing templates using Twig namespaceв syntax

* Use sonata templating service without activating framework.templating extension

* Make sonata.block.templating.helper a regular service

* Deprecation comments

* Fix CS errors
* DevKit updates

* Applied fixes from FlintCI (sonata-project#468)
@kunicmarko20 kunicmarko20 force-pushed the master_stable branch 3 times, most recently from b9a4857 to ecbc1c1 Compare February 1, 2018 20:33
@@ -11,35 +11,35 @@
<services>
<service id="sonata.block.service.container" class="%sonata.block.service.container.class%">
<tag name="sonata.block"/>
<argument/>
<argument type="service" id="templating"/>
<argument>sonata.block.container</argument>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carefull with all this. It was removed on master on purpose: #302

cc/ @core23

@kunicmarko20 kunicmarko20 merged commit f3a2978 into sonata-project:master Feb 2, 2018
@kunicmarko20 kunicmarko20 deleted the master_stable branch February 2, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants