-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend symfony DataCollector, do not serialize created_at as \DateTime #562
Conversation
Is there a way to add tests for this fix in order to avoid regressions? |
Ping @toooni |
@core23 I've added an object in a test trace which should make a problem if we wouldn't use the |
@toooni, could you please explain how to reproduce the issue this PR is fixing? |
Ping @toooni |
Could you please rebase your PR and fix merge conflicts? |
@phansys Here's a link to the issue (which is not associated with me) #556 |
I agree @toooni, thank you. |
@phansys Can't you just choose "Squash and merge" in the merge drop down menu? Else I can do this next week. |
Thanks @toooni |
Errors with deserialization for the profiling of blocks in debug mode with PHP 7.3
Instead of implementing an own solution for serialize/unserialize which resolves the PHP 7.3 bug https://bugs.php.net/bug.php?id=77302, I modified the
BlockDataCollector
to extendSymfony\Component\HttpKernel\DataCollector\DateCollector
. This way we take advantage of the already solved serialize/unserialize issue there.I am targeting this branch, because this affects all users with PHP 7.3. This fix keeps BC even for already serialized data.
Closes #556
Changelog