Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing parameters from parent class #231

Merged
merged 1 commit into from
Aug 15, 2016
Merged

Fixed missing parameters from parent class #231

merged 1 commit into from
Aug 15, 2016

Conversation

dmarkowicz
Copy link
Contributor

@dmarkowicz dmarkowicz commented Aug 12, 2016 •
edited by OskarStark

Changelog

### Fixed
- Fixed missing parameters from parent class in `ContextAwareAdmin::getPersistentParameters`

Subject

ContextAwareAdmin::getPersistentParameters() ignored all parameters introduced by extensions in parent AbstractAdmin class.
For example SonataClassificationBundle entities can be now translated by SonataTranslationBundle. SonataTranslationBundle introduce tl parameter which was ignored.

@core23
Copy link
Member

core23 commented Aug 12, 2016

LGTM

@OskarStark
Copy link
Member

LGTM 👍

@dmarkowicz it would be great if you could squash your commits into one, otherwise we will do this while merging it

@greg0ire greg0ire merged commit 626597a into sonata-project:3.x Aug 15, 2016
@greg0ire
Copy link
Contributor

greg0ire commented Aug 15, 2016 •
edited by OskarStark

Thanks @dmarkowicz

@dmarkowicz dmarkowicz mentioned this pull request Sep 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmarkowicz @core23 @OskarStark @greg0ire @SonataCI