Fix phpstan build #770
Merged
Fix phpstan build #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
reviewed
Nov 7, 2021
| @@ -105,28 +105,30 @@ private function configureAdmin(array $config, ContainerBuilder $container): voi | |||
| */ | |||
| private function registerSonataDoctrineMapping(array $config): void | |||
| { | |||
| foreach ($config['class'] as $type => $class) { | |||
| $classes = $config['class']; | |||
| foreach ($config['class'] as $class) { | |||
| if (!class_exists($class)) { | |||
| return; | |||
There was a problem hiding this comment.
We should throw an exception if the class does not exist
There was a problem hiding this comment.
Didn't want to change the behavior because I don't know this package but I thought about the same thing
core23
previously approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think finally it"s better to have protected properties in order to allow adding annotation to them.