Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

added grouped flash messages template #653

Merged

Conversation

silasjoisten
Copy link
Contributor

@silasjoisten silasjoisten commented Jan 15, 2019

Subject

I am targeting this branch, because this is a bc.

Closes #507

Changelog

  • flash message bag > 1 take grouped messaged
  • otherwise take the normal template

To do

  • add bool flag to configuration to allow disableing
  • Update the documentation
  • Update Translations

Look & Feel

Before

bildschirmfoto 2019-01-16 um 20 01 58

After

Collapsed

bildschirmfoto 2019-01-15 um 14 09 33

Expanded

bildschirmfoto 2019-01-15 um 14 09 41

@OskarStark
Copy link
Member

Are they collapsed by default?

@silasjoisten
Copy link
Contributor Author

@OskarStark yea, there collapsed by default.

@OskarStark
Copy link
Member

Before you could ready any of them, we should expand them by default IMO

WDYT @sonata-project/core ?

@kunicmarko20
Copy link
Contributor

can we get a before picture?

@silasjoisten
Copy link
Contributor Author

silasjoisten commented Jan 16, 2019

@OskarStark If we expand them by default, we wouldn't have a benefit of this. I mean if some one edits 20 entries in a list and we expand it by default i think its the same like currently. Maybe just a few pixel.

But we can find a middle way. so removing the headline. "ERFOLGREICH" and display just one message so like normal but with a more link which expands the area and show all of them. This may dont need a config option.

Like this:
Default collapsed
bildschirmfoto 2019-01-16 um 20 47 44

expanded
bildschirmfoto 2019-01-16 um 20 47 56

But this solution requires a bit of css. I did not see any css file in this bundle (except the vendors) how shall i solve this? I wouldn't like to do this inline or with a <style> tag... Any idea?

@OskarStark OskarStark merged commit 89ac082 into sonata-project:3.x Jan 17, 2019
@OskarStark
Copy link
Member

Thank you @silasjoisten 🎉

@kunicmarko20
Copy link
Contributor

there is a todo section that no one saw.......................................................................................................... 😅

@OskarStark
Copy link
Member

🙊 ups 😄

but I thought about it:
I merged this, because we expanded them by default and this is a design change which should be the default afterwards. We don't hide some messages, so do we really want another config option?

@silasjoisten
Copy link
Contributor Author

Waaiiiit

This is not inside!!

@silasjoisten
Copy link
Contributor Author

i just screenshoted something to ask you if this style is ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants