This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Make SonataEasyExtends optional #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
4 times, most recently
from
f454913
to
1dd5616
Compare
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
1dd5616
to
6b9adc4
Compare
phansys
previously approved these changes
Jul 22, 2020
core23
reviewed
Jul 22, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
6b9adc4
to
0ce0f06
Compare
|
Since this bundle does use 0.x released, this PR is a bit special, it is removing completely the EasyExtends and only relies on SonataDoctrineBundle |
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
0ce0f06
to
b317c19
Compare
VincentLanglet
previously approved these changes
Jul 25, 2020
phansys
reviewed
Jul 25, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
b317c19
to
f32c752
Compare
phansys
reviewed
Jul 25, 2020
phansys
previously approved these changes
Jul 25, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
f32c752
to
5372497
Compare
phansys
previously approved these changes
Jul 25, 2020
phansys
reviewed
Jul 25, 2020
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
VincentLanglet
approved these changes
Jul 25, 2020
phansys
approved these changes
Jul 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Part of: sonata-project/dev-kit#750
SonataEasyExtends is deprecated but it is used on many bundles, this makes it optional. This change is BC because if the user does not change anything it will continue using the deprecated code but with a message.
Changelog
To do