Fix reverseTransform method (#552)

A variable name was wrong and tests have been added.
sonata-project · Mar 22, 2021 · 0e3605d · 0e3605d
1 parent cc89819
commit 0e3605d
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 3 deletions.
diff --git a/src/Model/ModelManager.php b/src/Model/ModelManager.php
@@ -611,7 +611,7 @@ public function reverseTransform(object $object, array $array = []): void
         foreach ($array as $name => $value) {
             $property = $this->getFieldName($metadata, $name);
 
-            $this->propertyAccessor->setValue($instance, $property, $value);
+            $this->propertyAccessor->setValue($object, $property, $value);
         }
     }
 

diff --git a/tests/Model/ModelManagerTest.php b/tests/Model/ModelManagerTest.php
@@ -233,6 +233,11 @@ public function testGetParentMetadataForProperty(): void
         $this->assertSame($metadata->fieldMappings[$lastPropertyName]['type'], 'bool');
     }
 
+    /**
+     * NEXT_MAJOR: Remove this test.
+     *
+     * @group legacy
+     */
     public function testModelReverseTransformWithSetter(): void
     {
         $class = TestDocument::class;
@@ -252,6 +257,11 @@ public function testModelReverseTransformWithSetter(): void
         $this->assertTrue($object->schwifty);
     }
 
+    /**
+     * NEXT_MAJOR: Remove this test.
+     *
+     * @group legacy
+     */
     public function testModelReverseTransformFailsWithPrivateSetter(): void
     {
         $class = SimpleDocumentWithPrivateSetter::class;
@@ -262,6 +272,11 @@ public function testModelReverseTransformFailsWithPrivateSetter(): void
         $manager->modelReverseTransform($class, ['schmeckles' => 42]);
     }
 
+    /**
+     * NEXT_MAJOR: Remove this test.
+     *
+     * @group legacy
+     */
     public function testModelReverseTransformFailsWithPrivateProperties(): void
     {
         $class = TestDocument::class;
@@ -272,14 +287,45 @@ public function testModelReverseTransformFailsWithPrivateProperties(): void
         $manager->modelReverseTransform($class, ['plumbus' => 42]);
     }
 
-    public function testModelReverseTransformFailsWithPrivateProperties2(): void
+    public function testReverseTransformWithSetter(): void
+    {
+        $class = TestDocument::class;
+
+        $manager = $this->createModelManagerForClass($class);
+        $testDocument = new TestDocument();
+
+        $manager->reverseTransform(
+            $testDocument,
+            [
+                'schmeckles' => 42,
+                'multi_word_property' => 'hello',
+                'schwifty' => true,
+            ]
+        );
+
+        $this->assertSame(42, $testDocument->getSchmeckles());
+        $this->assertSame('hello', $testDocument->getMultiWordProperty());
+        $this->assertTrue($testDocument->schwifty);
+    }
+
+    public function testReverseTransformFailsWithPrivateSetter(): void
+    {
+        $class = SimpleDocumentWithPrivateSetter::class;
+        $manager = $this->createModelManagerForClass($class);
+
+        $this->expectException(NoSuchPropertyException::class);
+
+        $manager->reverseTransform(new SimpleDocumentWithPrivateSetter(1), ['schmeckles' => 42]);
+    }
+
+    public function testReverseTransformFailsWithPrivateProperties(): void
     {
         $class = TestDocument::class;
         $manager = $this->createModelManagerForClass($class);
 
         $this->expectException(NoSuchPropertyException::class);
 
-        $manager->modelReverseTransform($class, ['plumbus' => 42]);
+        $manager->reverseTransform(new TestDocument(), ['plumbus' => 42]);
     }
 
     /**