-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation for StringFilter format option #1061
Add deprecation for StringFilter format option #1061
Conversation
2f61fb7
to
bcf3200
Compare
I still see the single character mask as a valid use for this option. By instance |
I didn't know there is others mask. Maybe it's a use case but you will have There shouldn't be multiple way to contain something or start with something. |
It's enough for me. Just pointing that MSSQL has support for other masks. |
bcf3200
to
c0a4159
Compare
Done @phansys |
c0a4159
to
4537294
Compare
Subject
I am targeting this branch, because BC.
I already found weird the
format
option of theStringFilter
.If I look for something containing
foo
, there is IMHO no multiple way to check for this. It alwaysLIKE %foo%
.Now, this option is weirder since we have the
START WITH
and anEND WITH
checks.Why would these checks be made with
%foo
andfoo%
but the CONTAINS one could use another format than%foo%
?That's why I think we should deprecate the
format
option and remove it in the next major.Changelog