Translation is broken in oneToMany edit form #657
Conversation
| @@ -23,7 +23,7 @@ file that was distributed with this source code. | |||
| style="display:none;" | |||
| {% endif %} | |||
| > | |||
| {{ nested_field.vars.label|trans({}, nested_field.vars.translation_domain) }} | |||
| {{ nested_field.vars.label|trans({}, nested_field.vars['sonata_admin'].admin.translationDomain|default(nested_field.vars.translation_domain)) }} | |||
There was a problem hiding this comment.
This looks funny… what is vars['sonata_admin']? You're calling .admin on it…
There was a problem hiding this comment.
This was the old implementation
https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/651/files#diff-53ecac26c8f66fe65ba20a64eaf055b8L26
There was a problem hiding this comment.
Had a deeper look, I think that sonata_admin is an instance Sonata\AdminBundle\Form\Type\AdminType here, or something like that… so it must be fine (I hope)
There was a problem hiding this comment.
No idea how to solve this in 80 chars per line without destroying readability :/
There was a problem hiding this comment.
How about this :
{{ nested_field.vars.label
|trans({}, nested_field.vars['sonata_admin'].admin.translationDomain
|default(nested_field.vars.translation_domain)) }}The last line is indented twice to make it clear what is nested in what, exactly like we would do in php.
core23
force-pushed
the
patch/issue#656
branch
from
e4fd8ab
to
03c3165
Compare
|
Can you approve this @greg0ire ? |
|
LGTM 👍 |
I am targetting this branch, because this a bugfix.
Closes #656
Changelog
Subject
The PR #651 breaks the translation of oneToMany form fields in the table view.