Manual merge #792
Merged
Manual merge #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProxyQuery::addOrderedColumns does not support all syntax variants and operate on an unparsed query. AST walker solves adding missing items from OrderBy to Select problem in the right way. Fix Invalid PathExpression error.
jordisala1991
previously approved these changes
Jan 14, 2018
|
The build is broken because of doctrine type hints, and I think this should be fixed on the stable branch |
|
Type hints or because of the strict type declaration? |
|
unsure yet, but doctrine 2.6 is out, and I think it might have |
|
Extracting the interesting part: |
|
might be fixed in this bundle since its a passthrough |
|
Ohh yes.. I see better now. We have to fix it on stable indeed, add a cast should fix it right? |
|
Not sure yet, I think it might just be the tests that need fixing |
|
Updating because I don't reproduce it locally, I must have an old version of doctrine |
|
Ok now I reproduce the issue |
|
See #793 |
Should make Flint-CI happy
jordisala1991
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just approve, don't merge.