Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the fieldname is never null #793

Merged
merged 2 commits into from
Jan 14, 2018

Conversation

greg0ire
Copy link
Contributor

Should fix broken tests since Doctrine 2.6 is out.

jordisala1991
jordisala1991 previously approved these changes Jan 14, 2018
Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice field name

core23
core23 previously approved these changes Jan 14, 2018
@greg0ire greg0ire dismissed stale reviews from core23 and jordisala1991 via 4b561b0 January 14, 2018 19:14
@greg0ire
Copy link
Contributor Author

Argh please approve again guys

jordisala1991
jordisala1991 previously approved these changes Jan 14, 2018
@greg0ire
Copy link
Contributor Author

Oh no I touched the wrong comment

Should make Flint-CI happy
@jordisala1991
Copy link
Member

Ill wait until flintci says its okay

@greg0ire greg0ire closed this Jan 14, 2018
@greg0ire greg0ire reopened this Jan 14, 2018
@greg0ire greg0ire closed this Jan 14, 2018
@greg0ire greg0ire reopened this Jan 14, 2018
@greg0ire
Copy link
Contributor Author

@jordisala1991 Yaaaaay!

@jordisala1991 jordisala1991 merged commit 77f9fd2 into sonata-project:3.x Jan 14, 2018
@jordisala1991
Copy link
Member

Thanks @greg0ire

@greg0ire greg0ire deleted the non-null-fieldname branch January 14, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants