-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the fieldname is never null #793
Merged
jordisala1991
merged 2 commits into
sonata-project:3.x
from
greg0ire:non-null-fieldname
Jan 14, 2018
Merged
Ensure the fieldname is never null #793
jordisala1991
merged 2 commits into
sonata-project:3.x
from
greg0ire:non-null-fieldname
Jan 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jordisala1991
previously approved these changes
Jan 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice field name
core23
previously approved these changes
Jan 14, 2018
Argh please approve again guys |
jordisala1991
previously approved these changes
Jan 14, 2018
Oh no I touched the wrong comment |
Should make Flint-CI happy
greg0ire
force-pushed
the
non-null-fieldname
branch
from
January 14, 2018 19:15
4b561b0
to
78e1dd2
Compare
Ill wait until flintci says its okay |
@jordisala1991 Yaaaaay! |
jordisala1991
approved these changes
Jan 14, 2018
Thanks @greg0ire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix broken tests since Doctrine 2.6 is out.