-
-
Notifications
You must be signed in to change notification settings - Fork 93
Remove lower PHP versions - clean up build Matrix #417
Comments
@soullivaneuh did something change about the build process? i get lots of "wrong phpunit version for this version of php" on travisci. after #416, i restarted a build that was green last week. now its not anymore... or are we aware of travis-ci having made a mess? |
@dbu phpunit 6.0.0 is out, i suspect it has to do with this. IMO the phar we are downloading is no longer the 5.x phar. |
ah right. but smells like travis made a mistake, right? we rely on the
installed phpunit from how i read .travis.yml and the makefile
|
I don't think we do, I think we download it. We even download an old version for old php jobs. But the name does not contain the version number, which is bad. |
|
There are versioned downloads though : https://phar.phpunit.de/ |
ah, hidden in .travis where i seem to not have searched. is phpunit
install in the dev-kit thing of sonata, or should i fix it specifically
in this repository?
|
Please try fixing it specifically in this PR to prove that it works. I'm working on a dev-kit PR. |
Maybe we should take this as an occasion to switch to simple-phpunit ? See sonata-project/dev-kit#197 . WDYT? |
As promised: sonata-project/dev-kit#231 |
simple-phpunit would be a good idea imo. actually surprised we see no clash
on yml in sonata.
|
@dbu btw:i also had https://scrutinizer-ci.com/g/sonata-project/SonataDoctrinePhpcrAdminBundle/inspections/ee0847bd-4c6c-42e4-88d5-d42872d65951 the issue with dans glob repository. |
@ElectricMaxxx for your information, this bundle is not part of the CMF organization. So we are bound to support decision etc. made by the Sonata Project team. They use some fancy dev-kit tool to generate all config files, so I guess there is not much to do in this issue. |
@wouterj @ElectricMaxxx it should be ok on the stable branch, which should get merged on the master branch this night (right @soullivaneuh ?). If you are in a hurry, you can do that merge manually. |
there was a conflict. created a PR with a merge request where i solved the conflict. |
Great job @dbu! |
As we did it in the main CMF bundles, we should have an equal build matrix in here.
The text was updated successfully, but these errors were encountered: