Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Remove lower PHP versions - clean up build Matrix #417

Closed
ElectricMaxxx opened this issue Feb 3, 2017 · 16 comments
Closed

Remove lower PHP versions - clean up build Matrix #417

ElectricMaxxx opened this issue Feb 3, 2017 · 16 comments
Milestone

Comments

@ElectricMaxxx
Copy link
Contributor

As we did it in the main CMF bundles, we should have an equal build matrix in here.

@dbu
Copy link
Contributor

dbu commented Feb 3, 2017

@soullivaneuh did something change about the build process? i get lots of "wrong phpunit version for this version of php" on travisci. after #416, i restarted a build that was green last week. now its not anymore... or are we aware of travis-ci having made a mess?

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

@dbu phpunit 6.0.0 is out, i suspect it has to do with this. IMO the phar we are downloading is no longer the 5.x phar.

@dbu
Copy link
Contributor

dbu commented Feb 3, 2017 via email

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

I don't think we do, I think we download it. We even download an old version for old php jobs. But the name does not contain the version number, which is bad.

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

if [ ${TRAVIS_PHP_VERSION} '<' '5.6' ]; then

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

There are versioned downloads though : https://phar.phpunit.de/

@dbu
Copy link
Contributor

dbu commented Feb 3, 2017 via email

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

Please try fixing it specifically in this PR to prove that it works. I'm working on a dev-kit PR.

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

Maybe we should take this as an occasion to switch to simple-phpunit ? See sonata-project/dev-kit#197 . WDYT?

@greg0ire
Copy link
Contributor

greg0ire commented Feb 3, 2017

As promised: sonata-project/dev-kit#231

@dbu
Copy link
Contributor

dbu commented Feb 3, 2017 via email

@ElectricMaxxx
Copy link
Contributor Author

@wouterj
Copy link
Contributor

wouterj commented Feb 4, 2017

@ElectricMaxxx for your information, this bundle is not part of the CMF organization. So we are bound to support decision etc. made by the Sonata Project team. They use some fancy dev-kit tool to generate all config files, so I guess there is not much to do in this issue.

@greg0ire
Copy link
Contributor

greg0ire commented Feb 4, 2017

@wouterj @ElectricMaxxx it should be ok on the stable branch, which should get merged on the master branch this night (right @soullivaneuh ?). If you are in a hurry, you can do that merge manually.

@dbu
Copy link
Contributor

dbu commented Feb 6, 2017

there was a conflict. created a PR with a merge request where i solved the conflict.

@dbu dbu closed this as completed Feb 6, 2017
@greg0ire
Copy link
Contributor

greg0ire commented Feb 6, 2017

Great job @dbu!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants