Use fixed php version #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Feb 3, 2017
core23
requested changes
Feb 3, 2017
project/.travis/install_test.sh
Outdated
| @@ -5,9 +5,9 @@ mkdir --parents "${HOME}/bin" | |||
|
|
|||
| # PHPUnit install | |||
| if [ ${TRAVIS_PHP_VERSION} '<' '5.6' ]; then | |||
| PHPUNIT_PHAR=phpunit-old.phar | |||
| PHPUNIT_PHAR=phpuniti-4.8.9.phar | |||
There was a problem hiding this comment.
Do we need the patch level? phpunit-4.8.phar should work too
There was a problem hiding this comment.
It's not listed, but indeed, there's a nice 302.
project/.travis/install_test.sh
Outdated
| else | ||
| PHPUNIT_PHAR=phpunit.phar | ||
| PHPUNIT_PHAR=phpunit-5.7.9.phar |
|
What about adding phpunit as a dependency #197 ...? |
greg0ire
force-pushed
the
fixes/use-fixed-phpunit-versions
branch
from
0f97e8d
to
ac55376
Compare
|
You mean using simple-phpunit? I thought about it, but right now I can't (too long), so here is a quick fix before I look into it. |
core23
approved these changes
Feb 3, 2017
soullivaneuh
requested changes
Feb 3, 2017
project/.travis/install_test.sh
Outdated
| @@ -5,9 +5,9 @@ mkdir --parents "${HOME}/bin" | |||
|
|
|||
| # PHPUnit install | |||
| if [ ${TRAVIS_PHP_VERSION} '<' '5.6' ]; then | |||
| PHPUNIT_PHAR=phpunit-old.phar | |||
| PHPUNIT_PHAR=phpuniti-4.8.phar | |||
We don't want to use phpunit 6 yet.
greg0ire
force-pushed
the
fixes/use-fixed-phpunit-versions
branch
from
ac55376
to
5bd119f
Compare
soullivaneuh
approved these changes
Feb 3, 2017
|
The commit message was wrong. It's not about |
|
I'm very tired, sorry… |
|
I hope there are no other fuck ups… |
|
Didn't see that either... |
|
I'm trying out simple-phpunit now if anyone's interested sonata-project/SonataAdminBundle#4307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to use phpunit 6 yet.