-
-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
argh, seems as i would have to increas coverage before releasing |
No you don't have to, it's not marked as required. You do have to fix the tests though :P |
Uhh and that is strange. It is just a single build. And there each request on some http tooks to much time. |
We want to, but nobody has made a PR to change that yet. |
I will give it a try later or tomorrow morning. But the main problem looks more like the container has bad connectivity. |
I don't think so. I think the SAT solver is stuck. Maybe try bumping version constraints to the nearest patch version? @dbu had a similar issue IIRC, solved it using |
But the test call comes from make file, so that also comes from dev-kit? |
...which helps me find what I was talking about: sonata-project/dev-kit@768f3d6 |
Oh, i tought to go on RC tonight :-( |
Like I said, You can always try bumping e.g |
But wait, i released tree-browser-bundle with |
What makes you say that? The commit from @dbu has not landed on master. |
No idea, and also, touching that setting or even using @dev in a library does not sound great, even on a master branch. This should only be used in projects IMO, it's a hack. |
@greg0ire i removed that notice as i saw your answer. |
The tree-browser-bundle Release saved my PR :-) Ready to merge and RC-1 i would say then. |
Good job! |
just a clean up before the new release fix #449