Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Prepare new release #470

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Prepare new release #470

merged 1 commit into from
Jul 27, 2017

Conversation

ElectricMaxxx
Copy link
Contributor

just a clean up before the new release fix #449

@ElectricMaxxx ElectricMaxxx changed the base branch from 1.x to master July 27, 2017 18:58
@ElectricMaxxx
Copy link
Contributor Author

argh, seems as i would have to increas coverage before releasing

@greg0ire
Copy link
Contributor

No you don't have to, it's not marked as required. You do have to fix the tests though :P

@ElectricMaxxx
Copy link
Contributor Author

Uhh and that is strange. It is just a single build. And there each request on some http tooks to much time.
Btw why do we download a phpunit.phar, thought we use simple-phpunit?

@greg0ire
Copy link
Contributor

We want to, but nobody has made a PR to change that yet.

@ElectricMaxxx
Copy link
Contributor Author

I will give it a try later or tomorrow morning. But the main problem looks more like the container has bad connectivity.

@greg0ire
Copy link
Contributor

I don't think so. I think the SAT solver is stuck. Maybe try bumping version constraints to the nearest patch version? @dbu had a similar issue IIRC, solved it using travis_wait I think

@ElectricMaxxx
Copy link
Contributor Author

But the test call comes from make file, so that also comes from dev-kit?

@greg0ire
Copy link
Contributor

...which helps me find what I was talking about: sonata-project/dev-kit@768f3d6

@ElectricMaxxx
Copy link
Contributor Author

Oh, i tought to go on RC tonight :-(

@greg0ire
Copy link
Contributor

Like I said, You can always try bumping e.g ^1.0 to ^1.0.42, it could help, because it changes the space of the possibilities composer has to evaluate, but aside from that, sorry I have no solution.

@ElectricMaxxx
Copy link
Contributor Author

ElectricMaxxx commented Jul 27, 2017

But wait, i released tree-browser-bundle with min-stability:RC - unfortunatly. Can that be a reason for composer not to resolve a stable package, which i request here?

@greg0ire
Copy link
Contributor

So, the solution seems not to work. Or the time is not enough.

What makes you say that? The commit from @dbu has not landed on master.

@greg0ire
Copy link
Contributor

But wait, i released tree-browser-bundle with min-stability:RC - unfortunatly. Can that be a reason for composer not to resolve a stable package, which i request here?

No idea, and also, touching that setting or even using @dev in a library does not sound great, even on a master branch. This should only be used in projects IMO, it's a hack.

@ElectricMaxxx
Copy link
Contributor Author

@greg0ire i removed that notice as i saw your answer.

@ElectricMaxxx
Copy link
Contributor Author

The tree-browser-bundle Release saved my PR :-)

Ready to merge and RC-1 i would say then.

@greg0ire greg0ire merged commit f054065 into master Jul 27, 2017
@greg0ire greg0ire deleted the prepare_new_release branch July 27, 2017 21:13
@greg0ire
Copy link
Contributor

Good job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants