Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

DevKit updates for 1.x branch #497

Closed
wants to merge 1 commit into from
Closed

DevKit updates for 1.x branch #497

wants to merge 1 commit into from

Conversation

SonataCI
Copy link
Collaborator

@SonataCI SonataCI commented Oct 8, 2017

No description provided.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather not have those changes on the 1.x branch. short_array_syntax for example means we have to drop php 5.3 and 5.4. i'd rather wrap up 2.0 than do a new iteration of 1.x with lots of changes...

@greg0ire
Copy link
Contributor

greg0ire commented Oct 8, 2017

The plan is to drop 5.3-7.0

@dbu
Copy link
Contributor

dbu commented Oct 9, 2017

i like the plan, but can we limit that plan to the master (2.x) branch?

@soullivaneuh
Copy link
Member

@dbu This was discussed and voted here: sonata-project/dev-kit#285

Dropping dependencies support is semver compliant.

Two exceptions rules:

  • We must support PHP under the green maintaining zone (except for php 7.0 for this time).
  • We must support at least one LTS Symfony version if the package has SF dependencies.

This is a dev-kit update global for all projects.

@soullivaneuh
Copy link
Member

@dbu Another option: If you want to make it on 2.x this time, then we have to release a new major right now.

But next time, the versions dropping should follow #285.

@soullivaneuh
Copy link
Member

Correction: It's already released: https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/releases/tag/2.0.0

At least if you want to make release yourself, it would be great to warn it on Slack. ;-)

Right now the base branch is not good for dev-kit. I'll fix this.

@dbu
Copy link
Contributor

dbu commented Oct 9, 2017

uh, i did not really follow all that much. max seems to have released. should we create a 2.x branch now and make that the default branch? or make master default until we decide that we need to break BC?

@soullivaneuh
Copy link
Member

should we create a 2.x branch now and make that the default branch?

Yes. 2.x is now the stable branch and 1.x should not be maintained anymore.

Master is for BC breaking.

I'm managing that right now.

Ref: https://github.com/sonata-project/dev-kit/blob/master/project/CONTRIBUTING.md#the-base-branch

Please also note we dropped the three branches way support. Too heavy for the core: sonata-project/dev-kit#284

@soullivaneuh
Copy link
Member

Closing this one. Please see: sonata-project/dev-kit#300

@soullivaneuh soullivaneuh deleted the 1.x-dev-kit branch October 9, 2017 08:12
@dbu
Copy link
Contributor

dbu commented Oct 9, 2017

thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants