-
-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd rather not have those changes on the 1.x branch. short_array_syntax for example means we have to drop php 5.3 and 5.4. i'd rather wrap up 2.0 than do a new iteration of 1.x with lots of changes...
The plan is to drop 5.3-7.0 |
i like the plan, but can we limit that plan to the master (2.x) branch? |
@dbu This was discussed and voted here: sonata-project/dev-kit#285 Dropping dependencies support is semver compliant. Two exceptions rules:
This is a dev-kit update global for all projects. |
Correction: It's already released: https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/releases/tag/2.0.0 At least if you want to make release yourself, it would be great to warn it on Slack. ;-) Right now the base branch is not good for dev-kit. I'll fix this. |
uh, i did not really follow all that much. max seems to have released. should we create a 2.x branch now and make that the default branch? or make master default until we decide that we need to break BC? |
Yes. 2.x is now the stable branch and 1.x should not be maintained anymore. Master is for BC breaking. I'm managing that right now. Ref: https://github.com/sonata-project/dev-kit/blob/master/project/CONTRIBUTING.md#the-base-branch Please also note we dropped the three branches way support. Too heavy for the core: sonata-project/dev-kit#284 |
Closing this one. Please see: sonata-project/dev-kit#300 |
thanks a lot! |
No description provided.