Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Update symfony-cmf/resource-rest-bundle dependency #518

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

covex-nn
Copy link
Contributor

@covex-nn covex-nn commented Jan 19, 2018

I am targeting this branch, because this is a patch.

Changelog

### Changed

- Update symfony-cmf/resource-rest-bundle dependency

To do

  • Test 1.0.0
  • Test ^1.0.1

Subject

Travis for #517 failed because package symfony-cmf/resource-rest-bundle v1.0.0 was used there

@covex-nn
Copy link
Contributor Author

covex-nn commented Jan 19, 2018

https://travis-ci.org/sonata-project/SonataDoctrinePhpcrAdminBundle/builds/330697007 - require 1.0.0

Some jobs failed with error The service "jms_serializer.stopwatch_subscriber" has a dependency on a non-existent service "debug.stopwatch". Package symfony/stopwatch was not installed

@covex-nn
Copy link
Contributor Author

https://travis-ci.org/sonata-project/SonataDoctrinePhpcrAdminBundle/builds/330700102 - require ^1.0.1

All required jobs are passed. Package symfony/stopwatch was not installed too, but with symfony-cmf/resource-rest-bundle v1.0.1 there was installed jms/serializer-bundle v2.3.1 with patch schmittjoh/JMSSerializerBundle#625

@covex-nn covex-nn changed the title [WIP] Update symfony-cmf/resource-rest-bundle dependency Update symfony-cmf/resource-rest-bundle dependency Jan 19, 2018
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change, in the end. the joy of debugging :-D
thanks!

@dbu dbu merged commit 6000b62 into sonata-project:2.x Jan 19, 2018
Copy link
Member

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But do we allow 1.2 now?
IMO adding 1.0.0 to the conflict section would be better or use >=1.0.1

WDYT @greg0ire @dbu

@covex-nn
Copy link
Contributor Author

@OskarStark see https://getcomposer.org/doc/articles/versions.md#caret-version-range-

^1.2.3 is equivalent to >=1.2.3 <2.0.0

@covex-nn covex-nn deleted the composer branch January 19, 2018 08:57
@dbu
Copy link
Contributor

dbu commented Jan 19, 2018

@OskarStark i think you are thinking about the ~ operator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants