[WIP] Support Symfony 5 #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, note that these changes are already present at #302. |
|
@phansys I don't see an upgrade to version 5 of all SF components in that PR. |
You're right. Forget about it. I was just watching the dropped support for symfony / * <4.3. |
Merged
|
Could you please rebase your PR and fix merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR adds support for Symfony 5. The UserBundle does not support SF5 yet and has a dependency on the AdminBundle, so it will probably not support it for a while. I've removed it from dev-dependencies for now to check if the rest of the code works fine.
I am targeting this branch, because SF5 compatibility is required for this branch.
Changelog
To do