Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symfony 5 and Twig 3 support #308

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Add Symfony 5 and Twig 3 support #308

merged 2 commits into from
Jul 30, 2020

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jul 29, 2020 •
edited
Loading

Subject

I am targeting this branch, because this is needed to keep moving forward SonataAdminBundle major release and compat with Symfony 5.0.

Closes #305 .

Changelog

### Added
- Added support for Symfony 5
- Added support for Twig 3

@jordisala1991 jordisala1991 marked this pull request as ready for review July 29, 2020 08:06
@jordisala1991 jordisala1991 requested a review from a team July 29, 2020 08:06
@jordisala1991 jordisala1991 changed the title Upgrade to Symfony 5.0 and Twig 3 Add Symfony 5.0 and Twig 3 support Jul 29, 2020
VincentLanglet
VincentLanglet reviewed Jul 29, 2020
View reviewed changes
phpstan-baseline.neon
parameters:
ignoreErrors:
-
message: "#^Class Sonata\\\\UserBundle\\\\Model\\\\User not found\\.$#"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this new ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, you removed the "sonata-project/user-bundle": "^3.6 || ^4.0" dependency.
Should we keep it then ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep it yes. The integration with the user-bundle is deprecated. I just removed the required-dev dependency in order to be able to test with Symfony 5.0

@phansys
Copy link
Member

phansys commented Jul 29, 2020

I'd like to have at least a job checking the deprecated integration with sonata-project/user-bundle. Otherwise we could break that without any notice.

@jordisala1991 jordisala1991 mentioned this pull request Jul 29, 2020
Merged
@jordisala1991
Copy link
Member Author

Added the necessary code here, and also dev-kit PR: sonata-project/dev-kit#796 @phansys

@jordisala1991 jordisala1991 requested a review from a team July 29, 2020 16:20
@mathieupetrini mathieupetrini mentioned this pull request Jul 29, 2020
Closed
core23
core23 requested changes Jul 29, 2020
View reviewed changes
composer.json Outdated
"symfony/http-foundation": "^4.4",
"symfony/http-kernel": "^4.4",
"php": "^7.2",
"symfony/config": "^4.4 || ^5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony 5.0 is unsupported: https://symfony.com/releases/5.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jordisala1991 jordisala1991 changed the title Add Symfony 5.0 and Twig 3 support Add Symfony 5 and Twig 3 support Jul 30, 2020
@jordisala1991 jordisala1991 merged commit a582576 into sonata-project:2.x Jul 30, 2020
@jordisala1991 jordisala1991 deleted the feature/symfony5 branch July 30, 2020 12:45
@VincentLanglet
Copy link
Member

@jordisala1991 I just saw you let "symfony/templating": "^4.4",

@jordisala1991
Copy link
Member Author

yes, that is on purpose. Symfony templating does not exist on 5.0.

the ideal solution would be remove it, but that can only be safely implement on master because it implies a bc break here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys Awaiting requested review from phansys

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jordisala1991 @phansys @VincentLanglet @core23