Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan and psalm #477

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Nov 4, 2021

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Added PHPStan and Psalm

@jordisala1991 jordisala1991 marked this pull request as draft November 4, 2021 07:57
@jordisala1991 jordisala1991 force-pushed the feature/add-phpstan-psalm branch 2 times, most recently from ecaf2a3 to 29d5aec Compare November 4, 2021 08:04
@jordisala1991 jordisala1991 marked this pull request as ready for review November 5, 2021 07:51
@jordisala1991 jordisala1991 requested review from VincentLanglet and a team November 5, 2021 07:54
@VincentLanglet VincentLanglet requested a review from a team November 5, 2021 08:40
@VincentLanglet
Copy link
Member

Isn't it pedantic ?

@core23
Copy link
Member

core23 commented Nov 5, 2021

Isn't it pedantic ?

IMHO it's a patch, because there are some tiny code changes.

@jordisala1991 jordisala1991 added patch and removed minor labels Nov 5, 2021
@jordisala1991 jordisala1991 merged commit 05935ba into sonata-project:2.x Nov 5, 2021
@jordisala1991
Copy link
Member Author

Needs dev kit Pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants