Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sonata to v4 #1963

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jun 2, 2021

Subject

I am targeting this branch, because this is BC break

Not closing issues but there are some PRs with some of this code.

Changelog

### Added
- Add Compatibility with Sonata 4.

@jordisala1991 jordisala1991 changed the title [WIP ]Upgrade Sonata to v4 [WIP] Upgrade Sonata to v4 Jun 2, 2021
@jordisala1991
Copy link
Member Author

1) Sonata\MediaBundle\Tests\Provider\BaseProviderTest::testBuildEditForm
Undefined index: translation_domain

/home/runner/work/SonataMediaBundle/SonataMediaBundle/vendor/sonata-project/admin-bundle/src/Form/FormMapper.php:118
/home/runner/work/SonataMediaBundle/SonataMediaBundle/tests/Provider/BaseProviderTest.php:190
/home/runner/work/SonataMediaBundle/SonataMediaBundle/tests/Provider/AbstractProviderTest.php:77

A lot of this errors appear. @VincentLanglet can you help me? This comes from the admin-bundle, not sure if a bug or I am missing something.

@VincentLanglet
Copy link
Member

I would change

if ($group['translation_domain'] && !isset($fieldDescriptionOptions['translation_domain'])) {
    $fieldDescriptionOptions['translation_domain'] = $group['translation_domain'];
}

to

if (isset($group['translation_domain']) && !isset($fieldDescriptionOptions['translation_domain'])) {
     $fieldDescriptionOptions['translation_domain'] = $group['translation_domain'];
}

(or isset($group['translation_domain']) && $group['translation_domain'])

Can you try it ?

@jordisala1991
Copy link
Member Author

Solved by not mocking the admin.

@jordisala1991 jordisala1991 marked this pull request as ready for review June 3, 2021 07:00
@jordisala1991 jordisala1991 marked this pull request as draft June 3, 2021 07:25
@jordisala1991 jordisala1991 marked this pull request as ready for review June 4, 2021 06:26
@jordisala1991 jordisala1991 changed the title [WIP] Upgrade Sonata to v4 Upgrade Sonata to v4 Jun 4, 2021
@jordisala1991 jordisala1991 requested review from VincentLanglet and a team June 4, 2021 06:36
@jordisala1991
Copy link
Member Author

Needs: sonata-project/dev-kit#1558

@jordisala1991 jordisala1991 merged commit fc5e936 into sonata-project:master Jun 5, 2021
@jordisala1991 jordisala1991 deleted the feature/upgrade-sonata branch June 5, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants