-
-
Notifications
You must be signed in to change notification settings - Fork 94
Amqp remove deprecations #283
Amqp remove deprecations #283
Conversation
@greg0ire Should I make classes final? properties private? while I am on it. |
Hey there! It looks like you did not fill the pull request template properly. Maybe you Explaining why you target this branch
Here, you are supposed to replace
Searching and finding related issues
Please have a look at the list of issues and pull requests, and look for issues Filling the changelogThat one is really important to get right, because it will be used to craft a 3 important things:
Filling the TODO listIf you think your PR is ready, just remove it. If you have still some things Filling the SubjectLast but not least, describe your PR as well as you can. Bear in mind that some |
Sure! Just make sure to mention it the upgrade note, a bit like this: https://github.com/sonata-project/GoogleAuthenticator/blob/2.x/UPGRADE-2.0.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that's a lot less code, nice!
UPGRADE-4.0.md
Outdated
### Closed API | ||
|
||
* `AMQPBackendDispatcher` and `AMQPMessageIterator` classes are final. You cannot extend them. | ||
* `AMQPBackend` properties are private now. You cannot overwrite them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well technically, you can. It will just have no effect.
@greg0ire is there anything else that prevents us from merging it? |
Please address this: #283 (comment)
The lack of reviews. I try not to merge if I'm the only reviewer. |
|
Please address that part: "Explaining why you target this branch" |
done |
Thanks @makasim ! |
I am targeting this branch, because there is a BC-break.
Follow up #276
Changelog
Subject
The pull request remove previously deprecated stuff from the PR: #276