Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

DevKit updates for 3.x branch #330

Merged
merged 10 commits into from
Nov 20, 2018
Merged

DevKit updates for 3.x branch #330

merged 10 commits into from
Nov 20, 2018

Conversation

SonataCI
Copy link
Collaborator

@SonataCI SonataCI commented May 6, 2018

No description provided.

@greg0ire
Copy link
Contributor

greg0ire commented May 6, 2018

@makasim can you help with the Travis build? You introduced a deprecation for getChannel, but did not migrate code in src/Backend/AMQPBackend.php, and it still calls the deprecated method, which means our users are probably getting unfixable deprecations.

@makasim
Copy link
Contributor

makasim commented May 31, 2018

The master shouldn't use the deprecated code.

@greg0ire
Copy link
Contributor

greg0ire commented Jun 1, 2018

This is 3.x

@OskarStark
Copy link
Member

@makasim can you support us here?

Testing Sonata Notification Bundle Test Suite
................................................................. 65 / 78 ( 83%)
.............                                                     78 / 78 (100%)
Time: 7.51 seconds, Memory: 42.00MB
OK (78 tests, 233 assertions)
Generating code coverage report in Clover XML format ... done
Remaining deprecation notices (2)
The Sonata\NotificationBundle\Backend\AMQPBackendDispatcher::getChannel method is deprecated (since 3.2, will be removed in 4.x): 2x
    1x in AMQPBackendTest::testGetIteratorWithPrefetchCount from Sonata\NotificationBundle\Tests\Backend
    1x in AMQPBackendTest::testGetIteratorWithNoPrefetchCount from Sonata\NotificationBundle\Tests\Backend
make: *** [test] Error 1

@makasim
Copy link
Contributor

makasim commented Nov 20, 2018

Nothing to do with 3.x branch. It uses deprecated stuff. Master does not rely on it any more

@OskarStark
Copy link
Member

@greg0ire the weird part here is, that the other builds succeed... 🤔

@greg0ire
Copy link
Contributor

Nothing to do with 3.x branch. It uses deprecated stuff. Master does not rely on it any more

That's my point, 3.x can expose deprecated stuff, but shouldn't use it, people should be able to migrate to "the new way" in 3.x and get rid of the deprecations without upgrading to 4.0 (which they cannot for now)

@makasim
Copy link
Contributor

makasim commented Nov 20, 2018

@greg0ire @OskarStark see #341

@greg0ire greg0ire merged commit f5108aa into 3.x Nov 20, 2018
@greg0ire greg0ire deleted the 3.x-dev-kit branch November 20, 2018 12:43
@greg0ire
Copy link
Contributor

Finally :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants