This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 94
Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
phansys
suggested changes
Sep 15, 2020
wbloszyk
force-pushed
the
nelmio_3
branch
2 times, most recently
from
September 15, 2020 21:03
2583c7c
to
9c5aa6f
Compare
@phansys |
phansys
reviewed
Sep 15, 2020
I think this is RTM, but I generally wait for at least 2 approvals, if there are not controversial changes with active rejections. |
phansys
approved these changes
Sep 15, 2020
phansys
suggested changes
Sep 15, 2020
phansys
previously approved these changes
Sep 15, 2020
wbloszyk
force-pushed
the
nelmio_3
branch
3 times, most recently
from
September 22, 2020 19:39
0ff98f8
to
2fcfe68
Compare
phansys
reviewed
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing.
@phansys I know. I need UserBundle release to drop support for datagrid <3 first. then I can remove support for datagrid < 3.0 here. |
wbloszyk
force-pushed
the
nelmio_3
branch
4 times, most recently
from
September 29, 2020 15:58
30e9e54
to
b85a4a3
Compare
…low version 3 Thank you for help Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@sonata-project/contributors It is RTM. Please review it. |
phansys
previously approved these changes
Oct 1, 2020
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
phansys
approved these changes
Oct 1, 2020
VincentLanglet
approved these changes
Oct 1, 2020
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3.
I am targeting this branch, because these changes almost respect BC (with one, very little BC-break potential).
Changelog