Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #478

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Sep 2, 2020

Subject

Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3.

I am targeting this branch, because these changes almost respect BC (with one, very little BC-break potential).

Changelog

### Added
- support for `nelmio/api-doc-bundle` >= 3.6

@wbloszyk
Copy link
Member Author

@phansys
Do you think we can merge this PRs? or I should wait for other reviews?

UPGRADE-3.x.md Outdated Show resolved Hide resolved
@phansys
Copy link
Member

phansys commented Sep 15, 2020

Do you think we can merge this PRs? or I should wait for other reviews?

I think this is RTM, but I generally wait for at least 2 approvals, if there are not controversial changes with active rejections.

UPGRADE-3.x.md Outdated Show resolved Hide resolved
phansys
phansys previously approved these changes Sep 15, 2020
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@wbloszyk
Copy link
Member Author

@phansys I know. I need UserBundle release to drop support for datagrid <3 first. then I can remove support for datagrid < 3.0 here.

@wbloszyk wbloszyk requested a review from a team September 25, 2020 13:34
@wbloszyk wbloszyk force-pushed the nelmio_3 branch 4 times, most recently from 30e9e54 to b85a4a3 Compare September 29, 2020 15:58
…low version 3

Thank you for help

Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@wbloszyk
Copy link
Member Author

@sonata-project/contributors It is RTM. Please review it.

phansys
phansys previously approved these changes Oct 1, 2020
UPGRADE-3.x.md Outdated Show resolved Hide resolved
@phansys phansys added the minor label Oct 1, 2020
@wbloszyk wbloszyk requested a review from a team October 1, 2020 07:56
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
@wbloszyk wbloszyk requested a review from a team October 1, 2020 09:32
@VincentLanglet VincentLanglet merged commit ec0aac4 into sonata-project:3.x Oct 1, 2020
@VincentLanglet
Copy link
Member

Thanks

@wbloszyk wbloszyk deleted the nelmio_3 branch October 1, 2020 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants