allow to switch content language on list and filter by language #119
Conversation
|
@mcrinquand can you please review this PR and check if it still works as intended? and it would be awesome if you could add a bit of documentation how this is to be used. |
| @@ -2,8 +2,15 @@ | |||
| {% set admin = block_context.settings.admin %} | |||
| {% set locale_switcher_route = block_context.settings.locale_switcher_route %} | |||
| {% set locale_switcher_route_parameters = block_context.settings.locale_switcher_route_parameters %} | |||
| {% set currentLocale = object.locale %} | |||
There was a problem hiding this comment.
object is null in the list route, so trying to access its property throws an exception:
Impossible to access an attribute ("locale") on a null variable in SonataTranslationBundle:Block:block_locale_switcher.html.twig
|
@mcrinquand seems to not respond. if somebody has the time to wrap this up, would be cool. i only attempted to clean up the code, but don't have much time to follow up. |
|
Could you please rebase your PR and fix merge conflicts? |
|
any news on this PR @dbu ? |
|
no updates. i only updated the code started by @mcrinquand but don't have time to wrap this up. |
|
I merged conflicts, fixed null exception and added documentation for |
|
I think you should open a new one. |
|
It may be closed because #143 already merged. |
fix #81, fix #83
continuation of #83, #84