#81 add translation on list and on filters #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2016 11:47
…d and his translation, list block style
| public function configureQuery(AdminInterface $admin, ProxyQueryInterface $query, $context = 'list') | ||
| { | ||
| $this->getTranslatableListener()->setTranslatableLocale($this->getTranslatableLocale($admin)); | ||
| $this->getTranslatableListener()->setTranslationFallback(''); |
There was a problem hiding this comment.
@liquorvicar i guess this would add more to the problem you report in #61 - then again i think the fix likely will look the same as for the other occurance of this code.
|
looks good to me. i am not familiar with the sonataci quick check - that one seems to fail. |
|
Run |
@dbu : you have to click on "Console Output" to see something useful |
|
continued in #84 |
|
oh, and @mcrinquand: please comment something after updating a pull request. i only get email notifications on comments, not on new commits, so there is quite a risk i would not see new commits. |
This was referenced Jul 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the configureQuery, with the translatable listener the locale is changed for Doctrine and data are translated on the list.
translationFieldFilter is a callback method to use on doctrine_orm_callback filter to filter on field and on its translation.