Translate phpcr lists #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Aug 25, 2017
|
|
||
| /** | ||
| * @author Nicolas Bastien <nbastien.pro@gmail.com> | ||
| */ | ||
| class TranslatableAdminExtension extends AbstractTranslatableAdminExtension | ||
| { | ||
| /** | ||
| * @var LocaleChooser | ||
| */ | ||
| protected $localeChooser; |
There was a problem hiding this comment.
this should be private to prevent uncontrolled extension - unless there is a use case for it, properties should be private to make refactoring easier.
EmmanuelVella
force-pushed
the
phpcr-list-translation
branch
from
2b13967
to
cf82623
Compare
dbu
approved these changes
Aug 25, 2017
|
Hi, possible to merge this before the next tag? Thank you ! |
|
@greg0ire Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because it's a BC new feature.
Changelog
Subject
Hi, I just installed this bundle to translate phpcr elements, and I noticed the lists are not correctly translated.
I hope that's the correct way to achieve this !