-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate phpcr lists #177
Translate phpcr lists #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems sane to me, thanks! just a nitpick on property visibility.
|
||
/** | ||
* @author Nicolas Bastien <nbastien.pro@gmail.com> | ||
*/ | ||
class TranslatableAdminExtension extends AbstractTranslatableAdminExtension | ||
{ | ||
/** | ||
* @var LocaleChooser | ||
*/ | ||
protected $localeChooser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be private to prevent uncontrolled extension - unless there is a use case for it, properties should be private to make refactoring easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done !
2b13967
to
cf82623
Compare
Hi, possible to merge this before the next tag? Thank you ! |
@greg0ire Thank you ! |
I am targeting this branch, because it's a BC new feature.
Changelog
Subject
Hi, I just installed this bundle to translate phpcr elements, and I noticed the lists are not correctly translated.
I hope that's the correct way to achieve this !